Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Module reconfigure errors not surfacing in logs

Description

Steps to reproduce :

saw on this machine:

After successfully building, change the config to something that will make reconfigure return an error (ex invalid decoder_path on node component).

 

Expected behavior :

The error returned by reconfigure will be logged as error

 

Actual behavior :

No error is logged, the reconfigure appears successful from looking at the logs

Workaround : ( if available)

 

Robot Logs : ( where appropriate)

Docs changes clarification

None

Attachments

1

Activity

Dan Gottlieb April 2, 2025 at 3:51 PM

I’m seeing that even though the module reconfigure returns the error to the grpc layer, the modmanager calling ReconfigureResource is not getting any error back from the grpc client.

Pardon the ghost printlines I added:

Dan Gottlieb April 2, 2025 at 3:41 PM

I’ve uploaded a tgz (sorry about the files across directories that refer to my filepath layout).

It contains:

  • A patch for the RDK. This patch exposes a Reconfigure call to one of our test module components.

    • It allows for the reconfigure to either succeed or return an error based on some configuration value

    • It also patches the filesystem config watcher to notice renames (a file is copied over the existing config file)

  • A bash script adjacent to two config files.

    • Running this script will reproduce the problem (no log line including DBG. returning bad value. will appear, when it should)

      • It starts the viam server with a working config (config1) and

      • after 5 seconds swaps in config2 (a bad config)

    • The script also rebuilds the test module + viam server

Done

Details

Assignee

Team

NetCode

Priority

Fix versions

Docs site change needed?

Reporter

PagerDuty

Created April 1, 2025 at 8:43 PM
Updated April 8, 2025 at 9:54 PM
Resolved April 8, 2025 at 9:54 PM