[viam-orb-slam3] Implement orbslam3 model

Description

  • See the viamrobotics/viam-orb-slam3 repo structure for reference.

  • Copy/paste builtin.go into viam-orb-slam3.go. Copy orbslam_yaml.go into the same directory. Refactor the code:

    • Use the sensors as defined in slam/sensors

    • Utilize mono.go and rgbd.go to separate anything specific to each subAlgo, respectively.

    • Implement viam-orb-slam3.go as the main file that utilizes checking the subAlgo and using the functions and sensors as defined in mono.go, rgbd.go and each of the mono/sensors.go and rgbd/sensors.go files.

    • See this example to get started.

  • Rename slamMode to subAlgo.

  • Copy/paste builtin_test.go and orbslam_yaml_test.go into viam-orb-slam3 repo. Rename builtin_test.go to viam-orb-slam3_test.go. Copy/paste internal/testhelper/testhelper.go from rdk into viam-orb-slam3 if necessary. Refactor the tests so they are specific to orbslam and cover all functions well. Consider moving tests to other areas (e.g., slam/sensors) if it makes sense.

Docs changes clarification

None

Activity

Show:

Nick SanfordApril 12, 2023 at 2:22 PM

& I’ve closed this ticket as complete. The remaining planned work (refactoring tests & sensors.go) has been moved here:

Nick SanfordApril 12, 2023 at 2:16 PM

Moving to Needs Triage as orbslam is being deprioritized & removing from the sprint

cc

Zack PorterMarch 31, 2023 at 6:41 PM

Refactoring had not been completed:

Nick SanfordMarch 31, 2023 at 5:28 PM

it seems like all the pull requests are merged. What is left for this to be considered complete?

Done

Details

Assignee

Team

SLAM

Priority

Reporter

Sprint

Original estimate

PagerDuty

Created February 17, 2023 at 7:48 PM
Updated April 12, 2023 at 2:24 PM
Resolved April 12, 2023 at 2:22 PM